feature.*: allow cop_feature to expand #22824
Conversation
The initial implementation of feature bits for faster access to feature flags used a single U32 member in COP to store the bits, but we're now up to 24 features, so rather than leaving this to the last minute I've re-worked regen/feature.pl to allow multiple U32 fields.
|
I wonder if it would make if(cop.feature_bits[(num) / 32] & (1 << ((num) % 32)) { ... }Those div and mod operators would be all operating on compiletime constants so they'd decompose into basically the same values we have anyway, and I think it'll all get compiled into the same stuff; just we'd only be storing one number per feature, as we do now, rather than those two separate ones. |
I'm a bit indecisive here - I've looked at the pre-processed source often enough that I prefer simpler macros (though the stable has long since burned down here for the perl source), but a single source of truth for the bits are good too. |
The initial implementation of feature bits for faster access to feature flags used a single U32 member in COP to store the bits, but we're now up to 24 features, so rather than leaving this to the last minute I've re-worked regen/feature.pl to allow multiple U32 fields.
If you want to test this effectively you'll need to:
%featureinregen/feature.pl, I added:COP_FEATURE_SIZEin cop.hand test.
The low alphabet names here force some existing features into the second word so you're actually testing access and handling of that second word.